pdump: vendored libpcap, static pcap for controlplane#666
Open
sakateka wants to merge 1 commit intoyanet-platform:mainfrom
Open
pdump: vendored libpcap, static pcap for controlplane#666sakateka wants to merge 1 commit intoyanet-platform:mainfrom
sakateka wants to merge 1 commit intoyanet-platform:mainfrom
Conversation
sakateka
force-pushed
the
static-pdump-cp
branch
2 times, most recently
from
fc10df3 to
2657f1d
Compare
sakateka
changed the title
sakateka
force-pushed
the
static-pdump-cp
branch
from
2657f1d to
ec95ce9
Compare
sakateka
changed the title
sakateka
force-pushed
the
static-pdump-cp
branch
2 times, most recently
from
19ea48f to
f36b689
Compare
sakateka
force-pushed
the
static-pdump-cp
branch
from
f36b689 to
509eba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdump_cp no longer wires in DPDK’s rte_bpf via link_whole and the old libdpdk static library loop. It now takes a normal libdpdk_dep and adds a vendored libpcap 1.10.5: download (curl/wget), autotools configure with a stripped feature set, make install under the build tree, and declare_dependency with libpcap.a plus external/install/include for pcap/pcap.h.
CGO in ffi.go is updated to use those headers and to link libpcap statically (-Wl,-Bstatic -lpcap -Wl,-Bdynamic) next to libpdump_cp, so the final binary no longer depends on a separate plain -lpcap from the default search path.